Move TimedOutTestsListener from dlog to bookkeeper-common #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motiviation* To debugging CI problem observed at apache#1516 dlog uses a `TimedOutTestsListener` to dump the jvm stack when a junit test timed out. move this class to bookkeeper-common and built with `test-jar`, so it can be used across the project. *Changes* relocate `TimedOutTestsListener` and its related classes from distributedlog-common to bookkeeper-common.
|
@diegosalvi FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
This PR is to debug CI problems observed at #1516
Motivation
dlog uses a
TimedOutTestsListenerto dump the jvm stack when a junit test timed out.move this class to bookkeeper-common and built with
test-jar, so it can be used across the project.Changes
relocate
TimedOutTestsListenerand its related classes from distributedlog-common to bookkeeper-common.Related Issue: #1516